Jordan/2267+2278 validator table bugs #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2300 +/- ##
===========================================
- Coverage 96.76% 96.58% -0.19%
===========================================
Files 106 106
Lines 2318 2312 -6
Branches 117 117
===========================================
- Hits 2243 2233 -10
- Misses 63 66 +3
- Partials 12 13 +1
|
Codecov Report
@@ Coverage Diff @@
## develop #2300 +/- ##
==========================================
+ Coverage 96.76% 96.9% +0.14%
==========================================
Files 106 106
Lines 2318 2297 -21
Branches 117 113 -4
==========================================
- Hits 2243 2226 -17
+ Misses 63 62 -1
+ Partials 12 9 -3
|
fedekunze
reviewed
Mar 17, 2019
…ds and delegations with correct calulations
jbibla
changed the title
jbibla
changed the title
jbibla
commented
Mar 18, 2019
| }, | ||
| enrichedDelegates() { | ||
| return this.validators.map(v => | ||
| enrichedValidators({ |
fedekunze
reviewed
Mar 18, 2019
faboweb
reviewed
Mar 18, 2019
|
|
||
| <td | ||
| class="li-validator__commission" | ||
| > | ||
|
|
||
| 0.05% | ||
| 500.00% |
faboweb
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2267
Closes #2278
Closes #2237
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: